ANONYMOUS wrote:

> Hi professor, regarding Lab1 exercise 4 "Fix the code", the test codes for testSubtract() and testSubtractThrowsException().

Just "Arran", thanks.

> I am wondering if they are conflicting test cases? Since one should be asserting negative result and one is asserting for ArithmeticException for (can't return negative results). Therefore, isn't it not possible to make all the tests pass?

> Also testSubtractThrowsException() have num1 as 4 and num2 as 3, which shouldn't raise ArithmeticException. Based on the description ("can't return a negative result")

It looks like the test code has got out of sync with the lab worksheet at some point. The tests should be

  @Test
  public void testSubtract() {
      Calculator c = new Calculator(4, 3);
      int result = c.subtract();
      assertEquals(result, 1, "result should be 1");
  }

  @Test
  public void testSubtractThrowsException() {
      Calculator c = new Calculator(3, 4);
      Throwable exception = assertThrows(
          ArithmeticException.class, 
          () -> c.subtract()
      );
  }

I'll correct that.

Cheers

Arran